-
Notifications
You must be signed in to change notification settings - Fork 128
docs: update sharing and visibility sections for designs and workspaces #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: kirti763 <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Thank you for your contribution! Add it as an agenda item to the meeting minutes, if you would :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kirti763, could you please change these two to use the info
type alert box?
Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: kirti763 <[email protected]>
7e53f62
to
d9e9bbf
Compare
Signed-off-by: kirti763 <[email protected]>
Done, @zihanKuang |
@@ -41,7 +41,14 @@ To share and collaborate on a design with a very wide audience: | |||
|
|||
#### Publish the design | |||
|
|||
- If you need multiple people to open a design, publish the design then create a link to share to people with access. You can give edit access to people who need to edit or comment on the design. [Learn how to publish a design](#). | |||
- If you need multiple people to open a design, publish the design then create a link to share to people with access. You can give edit access to people who need to edit or comment on the design. [Learn how to publish a design](#). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
The jump link is missing:
/kanvas/designer/publishing-designs/
-
Regarding the phrase "publish the design then create a link to share to people with access"—could you clarify this? My understanding is that a published design is accessible to everyone. What does "people with access" refer to in this context if it's already public?
-
Could you explain "When a design is published (made public)"? I've tested publishing designs that are set to private, and the outcome regarding their published status and permissions seems to be the same as publishing public designs. It appears the private/public setting doesn't affect the published state.
- **Public:** Making a design "Public" makes it accessible to anyone on the internet who has the link or discovers it through public channels. | ||
|
||
{{< alert title="When a design is Public" type="info" >}} | ||
- Viewers and commenters can view, download, print, and copy the design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please clarify what "print" refers to here? Is it an action, and if so, does it correspond to a specific button?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: kirti763 <[email protected]>
626657c
to
32e3ce8
Compare
Hey @zihan just pushed the final tweaks! I was at KubeCon India and didn’t carry my laptop there, so thanks for the patience |
Notes for Reviewers
This PR fixes #497
Signed commits